Conversation
ee698bb to
2c8eee3
Compare
skylar-simoncelli
approved these changes
Oct 24, 2025
Contributor
|
Approved, though I don't entirely understand why we need to merge a second CI workflow into master. If your tests of Attic are working then can go straight to modifying the main ci.yml workflow and testing in a branch |
kpinter-iohk
approved these changes
Oct 24, 2025
Contributor
kpinter-iohk
left a comment
There was a problem hiding this comment.
Tested nix dev shell with my workflows, looking good! 🧑🍳👌
Member
Author
We can use it on the single CI job. I'll need to test it first on this branch with the rest of the workflow. thanks |
Contributor
|
Is this PR still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're currently using the nix devshells locally and in the CI, but with a raw cargo caching solution on our infra. This PR builds our substrate project using https://github.com/ipetkov/crane, a minimal nix-based wrapper that also excels at only rebuilding direct dependencies and not rebuilding upstream deps like the substrate project unless Cargo.lock changes for it. In the process it simplifies the caching solution and LOC required by using nix for caching, a task at which it already excels at.
This PR keeps the current devshell workflow and does not modify it. This PR does not modify the normal CI workflow as of yet-- instead for now it adds a new github action workflow for testing purposes.
Tested on macOS and Linux for building with cargo directly.
https://input-output.atlassian.net/browse/ETCM-12378?atlOrigin=eyJpIjoiNGZhOGYzMzdkZjEwNGU5NmI3MzMxODZjMDYzOGRmZmQiLCJwIjoiaiJ9
Checklist
changelog.mdfor affected crate