feat(cold): add max_logs parameter to get_logs#29
Merged
Conversation
Add a `max_logs: usize` parameter to `ColdStorage::get_logs` to cap result sets at the trait level, preventing unbounded memory usage from wide `eth_getLogs` queries. Backend implementations short-circuit early: - In-memory/MDBX: break out of the log collection loop at the limit - SQL: appends `LIMIT $N` to let the database engine stop scanning Bump workspace version to 0.5.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change `get_logs` semantics: return `TooManyLogs` error when the query would produce more than `max_logs` results instead of silently truncating. Each backend checks efficiently: - In-memory: returns error as soon as count exceeds limit - MDBX: collects up to max_logs+1, async wrapper checks and errors; also drains logs via `into_iter()` instead of cloning (ir is owned) - SQL: runs a cheap `COUNT(*)` query first, errors before fetching rows Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move the TooManyLogs check into the inner log collection loop so we bail out as soon as the limit is reached instead of collecting all results first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_logs: usizeparameter toColdStorage::get_logstrait method to cap result sets and prevent unbounded memory usage from wideeth_getLogsqueriesLIMIT $Nto the queryTest plan
cargo clippyforsignet-cold,signet-cold-mdbx,signet-cold-sqlwith--all-featuresand--no-default-featurescargo t -p signet-cold(in-memory conformance)cargo t -p signet-cold-mdbx --all-features(MDBX conformance)cargo t -p signet-cold-sql --all-features(SQLite conformance)./scripts/test-postgres.sh(PostgreSQL conformance)max_logs=2returns exactly 2 logs in correct order🤖 Generated with Claude Code