Draft
Conversation
|
|
gvd-adhoc
force-pushed
the
19.0-t-12345-gvd
branch
from
43e8f8c to
b421ffb
Compare
iga-adhoc
reviewed
Mar 17, 2026
estate/models/estate_property.py
Outdated
| @api.depends("offer_ids.price") | ||
| def _compute_best_price(self): | ||
| for record in self: | ||
| if record.offer_ids: |
There was a problem hiding this comment.
Esto puede ser un onliner algo como:
record.best_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0
| @api.depends("validity") | ||
| def _compute_date_deadline(self): | ||
| for record in self: | ||
| if record.create_date: |
There was a problem hiding this comment.
Aca desde odoo usamos mas el relativedelta, si queres buscate algunos ejemplos en le codigo, sino lo vemos
Author
There was a problem hiding this comment.
Pude ver algunos ejemplos, espero que me digas si usé correctamente la librería :)
| @@ -0,0 +1,15 @@ | |||
| { | |||
gvd-adhoc
force-pushed
the
19.0-t-12345-gvd
branch
from
b421ffb to
d5795b3
Compare
Author
|
@iga-adhoc ya completé los cambios, gracias por la revisión! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.