Skip to content

fix: mock network requests in e2es for dashboardsView#7139

Merged
wdoconnell merged 1 commit intomasterfrom
mock_network_request_in_markdown_e2e
Feb 20, 2026
Merged

fix: mock network requests in e2es for dashboardsView#7139
wdoconnell merged 1 commit intomasterfrom
mock_network_request_in_markdown_e2e

Conversation

@wdoconnell
Copy link
Contributor

This fixes a failing e2e test which appears to be reliant on the reachability of an external image asset. Replaced with a fixture using a small SVG that is already part of the assets in the repository, as the content of the image is not relevant to the test.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@wdoconnell wdoconnell requested review from a team as code owners February 20, 2026 16:01
Copy link
Contributor

@eatondustin1 eatondustin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱

@wdoconnell wdoconnell force-pushed the mock_network_request_in_markdown_e2e branch from 904267d to 23ec293 Compare February 20, 2026 16:14
Copy link
Contributor

@abshierjoel abshierjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙀

@wdoconnell wdoconnell added this pull request to the merge queue Feb 20, 2026
Merged via the queue into master with commit 69bb880 Feb 20, 2026
6 checks passed
@wdoconnell wdoconnell deleted the mock_network_request_in_markdown_e2e branch February 20, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants