SHEN-19483 Add REST Catalog stack trace to exception message#6
Merged
MoIMC merged 1 commit intoimc-trading:developfrom Mar 23, 2026
Merged
Conversation
When the Iceberg REST catalog server returns a 500 error, we currently
only include the error type and message in the resulting Python
exception raised. For example, for an UncheckedSQLException with message
"Unknown failure", we raise a
`ServerError('UncheckedSQLException: Unknown failure')`.
This is not very informative as often the root cause of these exceptions
is hidden in the server side stack trace. We already send the stack
trace as part of the error response, but we do not include it in the
Python exception message.
Let's include the stack trace in the exception message for 500 errors
(ServerError).
maxcmiller
force-pushed
the
SHEN-19483-rest-stack-trace
branch
from
cdfdbec to
1f3ef36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Iceberg REST catalog server returns a 500 error, we currently only include the error type and message in the resulting Python exception raised. For example, for an UncheckedSQLException with message "Unknown failure", we raise a
ServerError('UncheckedSQLException: Unknown failure').This is not very informative as often the root cause of these exceptions is hidden in the server side stack trace. We already send the stack trace as part of the error response, but we do not include it in the Python exception message.
Let's include the stack trace in the exception message for 500 errors (ServerError).