Conversation
More templates
@ice/create-pkg
ice-npm-utils
@ice/pkg
@ice/pkg-plugin-jsx-plus
@ice/pkg-plugin-mf
commit: |
There was a problem hiding this comment.
Pull request overview
Reverts the previously added “custom format” support (PR #671), removing the associated plugin API surface, task-registration logic, integration tests, and release metadata.
Changes:
- Removed
registerFormatfrom the plugin API types and from core plugin API wiring. - Simplified task registration by removing custom-format task handling in
registerTasks. - Deleted the integration test project/config/snapshots for
register-formatand removed the related changeset/prerelease entry.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/integration/plugins/plugins/register-format.ts |
Removes the integration-test plugin that exercised custom format registration. |
tests/integration/plugins/index.test.ts |
Removes the register-format integration test case from the test matrix. |
tests/integration/plugins/build.config.register-format.mts |
Removes the integration-test build config that enabled the register-format plugin. |
tests/integration/plugins/__snapshots__/index.test.ts.snap |
Removes snapshots produced by the deleted register-format integration test. |
packages/pkg/src/types.ts |
Removes custom-format task types and drops registerFormat from ExtendsPluginAPI. |
packages/pkg/src/core/register.ts |
Removes custom-format handling and updates registerTasks signature to no longer accept custom formats. |
packages/pkg/src/core/pkg.ts |
Removes exposure of registerFormat in pkg-scope plugin API merging. |
packages/pkg/src/core/create.ts |
Removes custom-format registry and updates call site to registerTasks(ctx). |
.changeset/violet-pots-brush.md |
Removes the changeset that introduced custom format support. |
.changeset/pre.json |
Removes the deleted changeset from the prerelease changeset list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.