Skip to content

revert: custom format #671#712

Merged
XGHeaven merged 1 commit intonextfrom
feat/remove-custom-format
Apr 3, 2026
Merged

revert: custom format #671#712
XGHeaven merged 1 commit intonextfrom
feat/remove-custom-format

Conversation

@XGHeaven
Copy link
Copy Markdown
Collaborator

No description provided.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

More templates

@ice/create-pkg

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/create-pkg@712

ice-npm-utils

npm i https://pkg.pr.new/ice-lab/icepkg/ice-npm-utils@712

@ice/pkg

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg@712

@ice/pkg-plugin-jsx-plus

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-jsx-plus@712

@ice/pkg-plugin-mf

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-mf@712

commit: 75fca6c

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previously added “custom format” support (PR #671), removing the associated plugin API surface, task-registration logic, integration tests, and release metadata.

Changes:

  • Removed registerFormat from the plugin API types and from core plugin API wiring.
  • Simplified task registration by removing custom-format task handling in registerTasks.
  • Deleted the integration test project/config/snapshots for register-format and removed the related changeset/prerelease entry.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration/plugins/plugins/register-format.ts Removes the integration-test plugin that exercised custom format registration.
tests/integration/plugins/index.test.ts Removes the register-format integration test case from the test matrix.
tests/integration/plugins/build.config.register-format.mts Removes the integration-test build config that enabled the register-format plugin.
tests/integration/plugins/__snapshots__/index.test.ts.snap Removes snapshots produced by the deleted register-format integration test.
packages/pkg/src/types.ts Removes custom-format task types and drops registerFormat from ExtendsPluginAPI.
packages/pkg/src/core/register.ts Removes custom-format handling and updates registerTasks signature to no longer accept custom formats.
packages/pkg/src/core/pkg.ts Removes exposure of registerFormat in pkg-scope plugin API merging.
packages/pkg/src/core/create.ts Removes custom-format registry and updates call site to registerTasks(ctx).
.changeset/violet-pots-brush.md Removes the changeset that introduced custom format support.
.changeset/pre.json Removes the deleted changeset from the prerelease changeset list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@XGHeaven XGHeaven merged commit 45b240f into next Apr 3, 2026
8 checks passed
@XGHeaven XGHeaven deleted the feat/remove-custom-format branch April 3, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants