Conversation
More templates
@ice/create-pkg
ice-npm-utils
@ice/pkg
@ice/pkg-plugin-jsx-plus
@ice/pkg-plugin-mf
commit: |
XGHeaven
force-pushed
the
feat/support-task-order
branch
from
46012d6 to
7b4fb72
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a global task ordering mechanism so tasks registered via registerTask can run in pre/builtin/normal/post phases, and ensures built-in tasks are treated as builtin during execution.
Changes:
- Add
TaskOrderandorder?: TaskOrderto task config typings. - Introduce
sortBuildTasksByOrderhelper and apply it ingetTaskRunners. - Update built-in task registration to assign
order: 'builtin', plus add unit tests for ordering.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pkg/src/types.ts | Adds TaskOrder and order to task configuration types. |
| packages/pkg/src/helpers/taskOrder.ts | New helper to sort build tasks by the global order. |
| packages/pkg/src/helpers/getTaskRunners.ts | Sorts tasks before creating runners to honor global ordering. |
| packages/pkg/src/core/register.ts | Marks built-in registered tasks as builtin order. |
| packages/pkg/tests/helpers/getTaskRunners.test.ts | Adds unit tests for sortBuildTasksByOrder. |
| .changeset/fair-items-help.md | Declares a minor release for the new feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
XGHeaven
force-pushed
the
feat/support-task-order
branch
from
7b4fb72 to
7ecd3bc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
XGHeaven
force-pushed
the
feat/support-task-order
branch
from
7ecd3bc to
829e8a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.