Open
Conversation
vinamelody
requested changes
Nov 5, 2022
|
|
||
| import SwiftUI | ||
|
|
||
| struct WorkshopDetailsView: View { |
Contributor
There was a problem hiding this comment.
let's make this just DetailView and have the SwiftUI previews
vinamelody
requested changes
Nov 5, 2022
| MACOSX_DEPLOYMENT_TARGET = 12.3; | ||
| MARKETING_VERSION = 1.0; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.niveumlabs.deepa; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.donchia.deepa; |
Contributor
There was a problem hiding this comment.
woops, don't commit this lol
| ForEach(viewModel.schedule) { information in | ||
| if Self.extractDate.string(from: information.startAt ?? Date.now) == "20/01/2022" { | ||
| VStack { | ||
| NavigationLink(destination: WorkshopDetailsView(title: information.title, startAt: information.startAt ?? Date.now, endAt: information.endAt ?? Date.now, talkDescription: information.talkDescription ?? "", activityName: information.activityName ?? "", speakers: information.speakers)) { |
Contributor
There was a problem hiding this comment.
Could you rename information to talk? structurally, a schedule is made up of talks.
then ... WorkshopDetailsView / DetailView takes the entire talk and decides how to render the talk
| if Self.extractDate.string(from: information.startAt ?? Date.now) == "20/01/2022" { | ||
| VStack { | ||
| NavigationLink(destination: WorkshopDetailsView(title: information.title, startAt: information.startAt ?? Date.now, endAt: information.endAt ?? Date.now, talkDescription: information.talkDescription ?? "", activityName: information.activityName ?? "", speakers: information.speakers)) { | ||
| ListContent(title: information.title, speakers: information.speakers, startAt: information.startAt ?? Date.now, endAt: information.endAt ?? Date.now) |
Contributor
There was a problem hiding this comment.
same as ListContent can be more specific named as TalkContent and takes the entire Talk
vinamelody
requested changes
Nov 5, 2022
| .cornerRadius(6) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I'd like to have the preview here too, something like this will be nice
struct WorkshopDetailsView_Previews: PreviewProvider {
static var previews: some View {
NavigationView {
WorkshopDetailsView(
title: "Awesome talk title",
startAt: Date(timeIntervalSinceNow: 1),
endAt: Date(timeIntervalSinceNow: 20),
talkDescription: "Lorem ipsum",
activityName: "normalTalk",
speakers: [
Speaker(
id: 90,
name: "Kale",
twitter: "kale",
company: "iOS Conf Sg",
imageUrl: "https://iosconf.sg/images/organisers/kale.jpeg"
)
])
}
}
}| func getURL2022(speakerImageURL: String) -> String { | ||
| if speakerImageURL.count > 0 { | ||
| var url = speakerImageURL | ||
| for (index, char) in "2022.".enumerated() { |
Contributor
There was a problem hiding this comment.
LOL this is a big no .... we should fix the backend value instead and not hard coding it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.