Open
Conversation
swsms
reviewed
Dec 19, 2018
src/flashcards/Main.java
Outdated
|
|
||
| logs.add(action); | ||
|
|
||
| switch (action) { |
There was a problem hiding this comment.
It may be useful to apply something like the command pattern together with a simple factory here instead of this big switch. It would isolate this code from possible changes in further. Each private method here can be represented like a small object which does an action.
Author
There was a problem hiding this comment.
Thanks for review. Committed changes about that.
There was a problem hiding this comment.
No problems. In general, your code looks pretty well.
Therefore, nothing to complain about here. You can use more advanced concepts, even if they are not yet explained in the topics. For example - Stream API and functional interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.