Stage #6 Processing coffee machine states#1
Open
kostylevv wants to merge 5 commits intohyperskill:masterfrom
Open
Stage #6 Processing coffee machine states#1kostylevv wants to merge 5 commits intohyperskill:masterfrom
kostylevv wants to merge 5 commits intohyperskill:masterfrom
Conversation
kostylevv
changed the title
swsms
reviewed
Oct 8, 2018
Contributor
swsms
left a comment
swsms
left a comment
There was a problem hiding this comment.
Good solution, congratulations!
src/coffeeMachine/Main.java
Outdated
| System.out.printf("%d ml of milk %n", cups*MILK); | ||
| System.out.printf("%d g of coffee beans %n", cups*BEANS); | ||
|
|
||
| CoffeeMachine machine = new CoffeeMachine.Builder(WATER_CONSUMPTION, |
Contributor
There was a problem hiding this comment.
It is an interesting idea to apply Builder in this project!
src/coffeeMachine/Main.java
Outdated
| int capacity = machine.getBrewCapacity(); | ||
|
|
||
| if (capacity > cups) { | ||
| System.out.printf("Yes, I can make that amount of coffee (and even %d more than that) %n", capacity-cups); |
Contributor
There was a problem hiding this comment.
Here are only two new spaces before the line
| } catch (Exception e) { | ||
| System.out.println(e.getMessage()); | ||
| } | ||
| }//eof while |
Contributor
There was a problem hiding this comment.
Is it important to add a comment with eof of a construction? It will be not good in production Java projects. If you want to know about eof after a '}' you may install a plugin for your IDE. Not all members of your team may need to see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.