Bump org.hsqldb:hsqldb from 2.7.0 to 2.7.2#36
Closed
dependabot[bot] wants to merge 8 commits intomainfrom
Closed
Conversation
…ential integrity of names) Add some semantic validation steps to the MiniLookml validator, to serve as examples for people building real validators. We check name uniqueness (that you can't have a dimension and a measure with the same name) and referential integrity of names (that if a join references a view "v1", then there must be a view named "v1" in the model). In future, perhaps these constraints could be defined in the schema; if so, the code could be removed from the validator. Fixes #35
Allow the parser position (`class Pos`) to contain nested positions. This will allow us to generate multi-part positions for code blocks. For example, sql_on: t1.c1 = t2.c2;; yields a code-property value spanning the whole "sql_on: t1.c1 = t2.c2;" but for detailed error reporting we need to know the exact location of the nested SQL string " t1.c2 = t2.c2". Fixes #32
Validate SQL fragments in a model. This step is called 'semantic validation', to distinguish it from the previous 'schema validation' step. Add class SqlValidator, powered by Calcite. Add the embedded HSQLDB Steelwheels database as a dependency, for testing. Fixes #34
…perties are required
In schema, add a `cardinality` property (with values
"optional" or "required") to the property object, and enforce
it in the schema validator.
For example, if we add "cardinality: required" to
mini-lookml-schema, as follows:
object_type: measure {
property: type {
type: measure_field_type
cardinality: required
}
...
}
then the following model is now invalid:
view: v1 {
measure: x {
type: count
}
measure: z {
}
dimension: y {}
}
because measure "z" should have a "type" property.
Enforce property.cardinality in the schema validator;
in Mini-LookML, measure.type is now required.
Fixes #33
…re that properties are mutually exclusive
Allow schema to declare that particular properties of an
object are mutually exclusive using the new
`cardinality_constraint` property. For example, if we add
cardinality_constraint: check_on {
properties: [sql_on, foreign_key]
}
to mini-lookml-schema, then the following view generates an
error that the same object cannot have both `foreign_key` and
`sql_on`.
view: v1 {
}
explore: e {
join: v1 {
sql_on: true;;
foreign_key: fk1
}
}
Fixes #31
Bumps org.hsqldb:hsqldb from 2.7.0 to 2.7.2. --- updated-dependencies: - dependency-name: org.hsqldb:hsqldb dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
8d1dbb7 to
10a974b
Compare
Author
|
Superseded by #44. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.hsqldb:hsqldb from 2.7.0 to 2.7.2.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)