Open
Conversation
I thought this is more easy for those who used to work with functions instead of classes.
Many times, data has np.nan . If this happen, RYScaler totally falls. I enhaced his behaviour substituting for the equivalent that doesn't takes in count np.nan
PEP8 review. Also I correct an error on DenseRotation class's documentation
Little modifications of documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modify definitions of classes (simplier for those who not used to use OOP). Also I sustituted
minandmaxfunctions in the scaler because those fall dealing with NaN values.Sorry for the question. Have you planned to adapt your library to make compilant with OpenCV v.4. ?
I already searched for the changes and I found, but I can't prove them on Anaconda yet.