[Subgraph] Update launcher references in Escrow functions #3837
Open
[Subgraph] Update launcher references in Escrow functions #3837
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Freestyle
Context behind the change
Adjusted the subgraph to stop relying on
event.transaction.fromfor escrow launcher related actions when MetaMask executes transactions through delegation addresses.handleLaunchedandhandleLaunchedV2now resolve the real launcher from the escrow contract on creation, andsetupandfundmappings reuse the storedescrow.launcher. This keeps launcher attribution correct in delegated MetaMask flows and prevents the subgraph from indexing the delegation executor as the actual launcher.How has this been tested?
Ran unit tests
Release plan
Deploy new Subgraph version and update SDK urls.
Potential risks; What to monitor; Rollback plan
Check that escrows are properly created, included the ones created with Metamask delegation