Merged
Conversation
The functions Horde_String::convertCharset and Horde_String::_pos are broken up to assist in better testability and additional tests for the newly introduced functions are added. This commit breaks compatibility with PHP 5.6 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> fixes #7
Apply charset validation fix from commit 63d0ea4 to src/HordeString.php equivalent. This prevents PHP errors when mb_substr is called with unsupporte charsets. The lib/Horde/String.php version was fixed in Feb 2025 by @TDannhauer but not applied to the PSR-4 version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the original @ziegenberg #7 to FRAMEWORK_6_0 branch.
This does not need a port to PSR-4 /src version.
Port another fix by @TDannhauer to src/