Added Default Client Id required for version 0.9 of Kafka Protocol.#22
Open
verrigo wants to merge 6 commits intohoppity:masterfrom
Open
Added Default Client Id required for version 0.9 of Kafka Protocol.#22verrigo wants to merge 6 commits intohoppity:masterfrom
verrigo wants to merge 6 commits intohoppity:masterfrom
Conversation
added 6 commits
September 6, 2016 13:22
This reverts commit 00ce75f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Kafka version requires that ClientId be set to a non empty string. Added a default client Id and the a new ClientId property to set it.