Draft
Conversation
jake-nyquist
reviewed
Feb 1, 2024
| message_queue.put_nowait(raw_message) | ||
|
|
||
| async def get_funding_info(self, trading_pair: str) -> FundingInfo: | ||
| index_price = await self._data_source.get_last_traded_price(trading_pair) |
Author
There was a problem hiding this comment.
The FundingInfo object has a field for both mark price and index price. This line is just getting the cached index price to include along with mark, etc.
jake-nyquist
reviewed
Feb 1, 2024
| async def get_funding_info(self, trading_pair: str) -> FundingInfo: | ||
| index_price = await self._data_source.get_last_traded_price(trading_pair) | ||
| funding_info = await self._data_source.get_funding_info(trading_pair) | ||
| funding_info.index_price = Decimal(index_price) |
There was a problem hiding this comment.
can you confirm that we're doing funding on the index?
jake-nyquist
reviewed
Feb 1, 2024
| EIP712_DOMAIN_VERSION = "1.0.0" | ||
|
|
||
| CONTRACT_ADDRESSES = { | ||
| DOMAIN: "0x64247BeF0C0990aF63FCbdd21dc07aC2b251f500", # TODO: Set to mainnet |
There was a problem hiding this comment.
can we set a "paper trading" relay?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR creates a Hook Odyssey connector
Tests performed by the developer:
No tests in this current version of the PR
Tips for QA testing: