Note that purge() is unimplemented in Hypercore 11#392
Open
lejeunerenard wants to merge 1 commit intoholepunchto:mainfrom
Open
Note that purge() is unimplemented in Hypercore 11#392lejeunerenard wants to merge 1 commit intoholepunchto:mainfrom
lejeunerenard wants to merge 1 commit intoholepunchto:mainfrom
Conversation
Contributor
|
lets just remove the api instead |
Contributor
|
Is the preferred alternative to have users get the entry, calculate the relevant indexes, and delete from rocksdb themselves? |
Contributor
|
nah, we should add a proper api for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed when Hypercore refactored to use rocksdb. In the hypercore code base the tests are commented out with a 'TODO'.