Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds esbuild compilation support as an alternative build mode for faster compilation of Highcharts source files. Users can opt into esbuild by adding ?esbuild to any request URL.
Changes:
- Adds new esbuild compilation pipeline that integrates with
@highcharts/highcharts-utils - Implements query parameter detection (
?esbuild) to route requests to the esbuild compiler - Adds comprehensive test coverage for the new esbuild functionality
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test.js | Adds esbuild test file to the test suite |
| test/esbuild.js | New comprehensive test suite covering esbuild compilation functions and core module exports |
| static/index.html | Updates example URLs to demonstrate esbuild mode with ?esbuild query parameter |
| package.json | Adds required dependencies: esbuild, esbuild-plugin-replace-regex, semver, and highcharts-utils |
| app/handlers.js | Implements esbuild mode detection and adds serveEsbuildFile handler function |
| app/esbuild.js | New module providing esbuild compilation functionality with caching and error handling |
| README.md | Extensive documentation of esbuild mode including usage, benefits, and troubleshooting |
| Dockerfile | Minor comment correction removing outdated "(yarn)" reference |
| "webpack-cli": "^5.1.4" | ||
| }, | ||
| "devDependencies": { | ||
| "@highcharts/highcharts-utils": "github:highcharts/highcharts-utils#enhancement/refactor-compile-on-demand", |
There was a problem hiding this comment.
The dependency references a GitHub branch (enhancement/refactor-compile-on-demand) rather than a stable release version. For production deployments, consider using a specific commit SHA, tag, or published npm version to ensure reproducible builds and avoid breaking changes from branch updates.
Suggested change
| "@highcharts/highcharts-utils": "github:highcharts/highcharts-utils#enhancement/refactor-compile-on-demand", | |
| "@highcharts/highcharts-utils": "^1.5.6", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.