feat: optionally set a different default Arduino stream#26
Open
pillo79 wants to merge 1 commit intohideakitai:mainfrom
Open
feat: optionally set a different default Arduino stream#26pillo79 wants to merge 1 commit intohideakitai:mainfrom
pillo79 wants to merge 1 commit intohideakitai:mainfrom
Conversation
To support the Arduino UNO Q it is important to avoid accessing the 'Serial' object from this library. This commit allows the user to set the default stream to something else, such as 'Serial1' or 'Serial2', by defining 'DEBUGLOG_DEFAULT_ARDUINO_STREAM' before including the library. This change is backward compatible, as the default will still be 'Serial' if the macro is not defined. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support the Arduino UNO Q use cases, it is important to avoid accessing the
Serialobject from this library.This PR allows the user to set the default stream to something else, such as
Serial1orSerial2, by definingDEBUGLOG_DEFAULT_ARDUINO_STREAMbefore including the library. This change is backward compatible, as the default will still beSerialif the macro is not defined.