Conversation
Owner
|
Cool! Could we still keep the install script around and potentially just move the deleted code into its own file that loads the file here? That way both install methods work. |
jgarte
force-pushed
the
jgarte-patch-2
branch
from
04af2d3 to
4b7bce6
Compare
Contributor
Author
|
@hellerve Sure, I updated the PR to remove that commit. I'll need to do some more testing on the asd file I added here. It's still currently a work in progress but wanted to share my work so far here in case lispers in the community would like to give feedback and code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17, #28 and #29