Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
========================================
Coverage 94.58% 94.59%
========================================
Files 393 394 +1
Lines 25083 25276 +193
========================================
+ Hits 23726 23910 +184
- Misses 1357 1366 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def __init__(self, service_name, name, context): | ||
| super(PartitionSpecificProxy, self).__init__(service_name, name, context) | ||
| partition_key = context.serialization_service.to_data(string_partition_strategy(name)) |
There was a problem hiding this comment.
why is it hard coded string_partition_strategy? In Java, this is configurable.
There was a problem hiding this comment.
Ported that directly from the asyncore client.
I don't think any client other than Java has that configurable.
There was a problem hiding this comment.
ok, may be we can open a todo issue for this. if different strategy was used in the cluster, probably wrong partition id will be calculated by the client which may cause complicated problems.
3 participants
Straightforward port of
Listto asyncio.