Skip to content

the great protocol refactor#90

Open
90-008 wants to merge 68 commits intomainfrom
chat/invite-events
Open

the great protocol refactor#90
90-008 wants to merge 68 commits intomainfrom
chat/invite-events

Conversation

@90-008
Copy link
Member

@90-008 90-008 commented Feb 3, 2022 •
edited
Loading

Resolves #84
Resolves #92
Resolves #93
Resolves #94
Resolves #96

Voice is completely changed (now called webrtc service).

things that will need migration

  • chat.v1.Guild
    • guild kind was removed
  • chat.v1.Message
    • Content changes
      • Embed changes
      • Attachment changes
      • Reaction changes
  • profile.v1.Profile
    • UserStatus changes

@90-008 90-008 added the enhancement New feature or request label Feb 3, 2022
@90-008 90-008 changed the title feat(chat): add invite created / deleted / used events feat: add invite created / deleted / used events, documentation Feb 6, 2022
@90-008 90-008 mentioned this pull request Feb 6, 2022
Closed
4 tasks
@90-008 90-008 requested review from bluskript and sowelipililimute and removed request for sowelipililimute February 6, 2022 01:51
bluskript
bluskript reviewed Feb 7, 2022
View reviewed changes
sowelipililimute
sowelipililimute requested changes Feb 11, 2022
View reviewed changes
@90-008 90-008 changed the title feat: add invite created / deleted / used events, documentation the great protocol refactor Feb 11, 2022
bluskript
bluskript approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@bluskript bluskript left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solves a lot of technical debt issues and protocol limitations we were facing in the older versions, good work!

@sowelipililimute
Copy link
Member

sowelipililimute commented Feb 11, 2022

this is a severely breaking change; we agreed not to do these

90-008 and others added 30 commits April 2, 2022 04:08
@90-008
feat: bot tokens (#99)
9c39c99 
Co-authored-by: spiral <spiral@spiral.sh>
@90-008
feat: separate private channels from guilds (#100)
94b1112 
Co-authored-by: spiral <spiral@spiral.sh>
@90-008
feat: refactor actions (#101)
d9f35a3 
Co-authored-by: spiral <spiral@spiral.sh>
@90-008
fix(chat): message name typo
ac35c01
@90-008
fix(chat): add missing get private channel list rpc
6ad5b1d
@90-008
fix(chat): remove unused import
a2d4082
@90-008
fix(chat): fix a few fields that need to be optional
90a1fc0
@90-008
fix(chat): typing request should have an optional guild id
ffb8ca8
@90-008
fix: fix location.guild_invite_id to be string, remove invite_id from…
6bbbadc 
… UserRejectedInvite, add location to PendingInvite
@90-008
fix: Invite* events should also use location
f424aa0
@90-008
feat(chat): add GetOutgoingPendingInvites to let users fetch the invi…
63b855f 
…tes they have sent that haven't been rejected
@90-008
feat(chat): add DeleteOutgoingInvite to delete and cancel an outgoing…
fb9028f 
… invite
@90-008
fix(chat): Reject/Ignore pending invite requests should use PendingIn…
14be6dd 
…vite
@90-008
feat(chat): allow specifying pack_id optionally in Emoji format
cc41fa8
@90-008
refactor(chat): Invite* events should use Pending/Outgoing Invite
abd8124
@90-008
refactor(chat): make more server_ids optional
317b784
@90-008
feat(sync): add inviter_id to user rejected invite
848b617
@90-008
feat: remove outgoing invites, add join private channel
c964791
@90-008
fix(chat): remove outgoing invite usage
724cf95
@90-008
fix(chat): add field names
0981d97
@90-008
refactor(chat): make pending invite endpoints not use pending invite …
87a9359 
…object
@90-008
docs(chat): document when a pending invite is unique
ca3ebac
@90-008
feat(chat): add leave private channel endpoint
db38966
@90-008
refactor(chat): rename is_locked to is_dm, let create private channel…
64ea59e 
… join the user to dm if already joined before
@90-008
refactor(chat): make another server id optional
772798b
@bluskript
add private channel data to get rpc, add optional name
b265a91
@bluskript
separate private channel fetching and its data
b47c27f
@90-008
refactor(chat): GetPrivateChannelData -> GetPrivateChannel
598e413
@90-008
refactor(chat): dont use optional name in UpdatePrivateChannelNameReq…
e438b77 
…uest
@90-008
feat(chat): consolidate UpdatePrivateChannel\* RPCs into one, add Pri…
a1319c7 
…vateChannelUpdated stream event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sowelipililimute sowelipililimute sowelipililimute requested changes

@bluskript bluskript bluskript approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

3 participants

@90-008 @sowelipililimute @bluskript