Skip to content

HCK-15030: FE duality view annotations #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivan-m-dev merged 1 commit into from
Feb 26, 2026
Merged

HCK-15030: FE duality view annotations #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...d_engineering/ddlProvider/ddlHelpers/dualityViewFeHelper/abstractDualityViewDdlCreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const { getViewName } = require('../../../utils/general');
const { DualityViewPropertiesType } = require('../../../enums/DualityViewPropertiesType');
const { getAnnotationsString } = require('../../../utils/getAnnotationsString');

/**
* @abstract
Expand Down Expand Up @@ -176,9 +177,10 @@ class AbstractDualityViewFeDdlCreator {

/**
* @param createViewDto {CreateDualityViewDto}
* @param prepareName {Function}
* @return {string}
* */
getCreateJsonRelationalDualityViewHeadingDdl(createViewDto) {
getCreateJsonRelationalDualityViewHeadingDdl(createViewDto, prepareName) {
const { jsonSchema, view } = createViewDto;
const template = this._ddlTemplates?.dualityView?.createJsonRelationalDualityViewHeading || '';

Expand All @@ -187,12 +189,14 @@ class AbstractDualityViewFeDdlCreator {
const editionableStatement = this._getEditionableStatement(jsonSchema);
const viewName = getViewName(view);
const ddlViewName = this._getNamePrefixedWithSchemaName(viewName, view.schemaName);
const annotations = getAnnotationsString(prepareName)(view.viewAnnotations);

const params = {
orReplaceStatement,
forceStatement,
editionableStatement,
viewName: ddlViewName,
annotations: annotations ? `\n\t${annotations}` : '',
};
return this._assignTemplates(template, params);
}
Expand All @@ -210,7 +214,7 @@ class AbstractDualityViewFeDdlCreator {
* @return {string}
* */
convertDualityViewToDdl(createViewDto) {
const heading = this.getCreateJsonRelationalDualityViewHeadingDdl(createViewDto);
const heading = this.getCreateJsonRelationalDualityViewHeadingDdl(createViewDto, this._prepareName);
const body = this.getDualityViewBodyDdl(createViewDto);
return heading + '\n' + body + '\n';
}
Expand Down
2 changes: 1 addition & 1 deletion forward_engineering/ddlProvider/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module.exports = {

dualityView: {
createJsonRelationalDualityViewHeading:
'CREATE${orReplaceStatement}${forceStatement}${editionableStatement} JSON RELATIONAL DUALITY VIEW ${viewName} AS',
'CREATE${orReplaceStatement}${forceStatement}${editionableStatement} JSON RELATIONAL DUALITY VIEW ${viewName}${annotations} AS',

sql: {
tableTagsStatement:
Expand Down