Skip to content

HCK-14858: Custom scripts in ALTER statements #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaliiBedletskyi merged 7 commits into from
Feb 25, 2026
Merged

HCK-14858: Custom scripts in ALTER statements #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
694f059
refactor: use shared methods for better readability
AlikRakhmonov Feb 23, 2026
b34d5f2
fix: rollback flatMap
AlikRakhmonov Feb 23, 2026
e920240
refactor: AlterScriptDto should contains single script/statement
AlikRakhmonov Feb 23, 2026
abae0ce
fixes
AlikRakhmonov Feb 23, 2026
4f4722c
remove duplications
AlikRakhmonov Feb 23, 2026
c763bb0
set script type
AlikRakhmonov Feb 24, 2026
c240474
fix key mapping
AlikRakhmonov Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 49 additions & 38 deletions forward_engineering/alterScript/alterScriptBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,34 +3,49 @@ const { AlterScriptDto } = require('./types/AlterScriptDto');
const { commentIfDeactivated } = require('../utils/general');

/**
* @return {(dtos: AlterScriptDto[], shouldApplyDropStatements: boolean) => string}
* @param {AlterScriptDto} dtos
* @param {boolean} shouldApplyDropStatements
* @return {AlterScriptDto}
* */
const commentDto = (dto, shouldApplyDropStatements) => {
let script = dto.script;
const shouldDeactivate = dto.isActivated === false || (!shouldApplyDropStatements && dto.isDropScript);
if (shouldDeactivate) {
script = commentIfDeactivated(script, {
isActivated: false,
isPartOfLine: false,
});
}
return { ...dto, script };
};

/**
* @param {AlterScriptDto[]} dtos
* @param {boolean} shouldApplyDropStatements
* @return {AlterScriptDto[]}
* */
const commentDtosIfRequired = (dtos, shouldApplyDropStatements) => {
return dtos.reduce((finalDtos, dto) => {
if (!dto) {
return finalDtos;
}
return [...finalDtos, commentDto(dto, shouldApplyDropStatements)];
}, []);
};

/**
* @param {AlterScriptDto[]} dtos
* @param {boolean} shouldApplyDropStatements
* @return {string}
* */
const joinAlterScriptDtosIntoScript = (dtos, shouldApplyDropStatements) => {
return dtos
.map(dto => {
if (dto.isActivated === false) {
return dto.scripts.map(scriptDto =>
commentIfDeactivated(scriptDto.script, {
isActivated: false,
isPartOfLine: false,
}),
);
}
if (!shouldApplyDropStatements) {
return dto.scripts.map(scriptDto =>
commentIfDeactivated(scriptDto.script, {
isActivated: !scriptDto.isDropScript,
isPartOfLine: false,
}),
);
}
return dto.scripts.map(scriptDto => scriptDto.script);
})
.flat()
.filter(Boolean)
.map(scriptLine => scriptLine.trim())
.filter(Boolean)
.join('\n\n');
return dtos.reduce((finalScript, dto) => {
if (!dto) {
return finalScript;
}
const { script } = commentDto(dto, shouldApplyDropStatements);
return `${finalScript}\n\n${script}`;
}, '');
};

/**
Expand All @@ -44,7 +59,9 @@ const buildEntityLevelAlterScript = (data, app) => {
option => option.id === 'applyDropStatements' && option.value,
);

return joinAlterScriptDtosIntoScript(alterScriptDtos, shouldApplyDropStatements);
return data.options?.keepDtos
? commentDtosIfRequired(alterScriptDtos, shouldApplyDropStatements)
: joinAlterScriptDtosIntoScript(alterScriptDtos, shouldApplyDropStatements);
};

/**
Expand All @@ -54,11 +71,7 @@ const buildEntityLevelAlterScript = (data, app) => {
* */
const doesEntityLevelAlterScriptContainDropStatements = (data, app) => {
const alterScriptDtos = getAlterScriptDtos(data, app);
return alterScriptDtos.some(
alterScriptDto =>
alterScriptDto.isActivated &&
alterScriptDto.scripts.some(scriptModificationDto => scriptModificationDto.isDropScript),
);
return alterScriptDtos.some(alterScriptDto => alterScriptDto?.isActivated && alterScriptDto.isDropScript);
};

const mapCoreDataForContainerLevelScripts = data => {
Expand All @@ -81,7 +94,9 @@ const buildContainerLevelAlterScript = (data, app) => {
option => option.id === 'applyDropStatements' && option.value,
);

return joinAlterScriptDtosIntoScript(alterScriptDtos, shouldApplyDropStatements);
return preparedData.options?.keepDtos
? commentDtosIfRequired(alterScriptDtos, shouldApplyDropStatements)
: joinAlterScriptDtosIntoScript(alterScriptDtos, shouldApplyDropStatements);
};

/**
Expand All @@ -92,11 +107,7 @@ const buildContainerLevelAlterScript = (data, app) => {
const doesContainerLevelAlterScriptContainDropStatements = (data, app) => {
const preparedData = mapCoreDataForContainerLevelScripts(data);
const alterScriptDtos = getAlterScriptDtos(preparedData, app);
return alterScriptDtos.some(
alterScriptDto =>
alterScriptDto.isActivated &&
alterScriptDto.scripts.some(scriptModificationDto => scriptModificationDto.isDropScript),
);
return alterScriptDtos.some(alterScriptDto => alterScriptDto?.isActivated && alterScriptDto.isDropScript);
};

module.exports = {
Expand Down
Loading