Draft
Conversation
Fix typo "Logival Volumes" → "Logical Volumes" in the lvm boot option description. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
grml.org and wiki.grml.org support HTTPS. Update all plain HTTP URLs to use HTTPS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
portmap was replaced by rpcbind in Debian (and in all Grml flavours, per commit ac64887). Update the example service name accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
reiserfsprogs was dropped from all Grml flavours (commit 73fb627). Use ext4 as the example filesystem for the isofrom= prefix instead, as it is far more commonly used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The -H flag is deprecated in current mkpasswd (from whois package) in favor of -m. Additionally, md5 password hashes are considered insecure; use sha-512 instead. Also remove the "available in Grml >=2013.09" note as that version is long past. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The /dev/hd* device naming scheme is from the old IDE subsystem, which was removed from the Linux kernel in version 5.14. All IDE devices have been handled by libata (using /dev/sd*) for many years. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The old ieee1394 firewire stack was removed from the Linux kernel in version 2.6.37 (2011). The "new (Juju)" firewire stack (firewire-core) is now the only firewire stack, so drop the "new (Juju)" qualifier. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The IDE subsystem was removed from the Linux kernel in version 5.14 (2021). All IDE devices are now handled by the libata subsystem. The ide?= kernel parameter no longer exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace /dev/fd0 (floppy disk) and /dev/hda2 (old IDE naming) with current device names. Floppy drives are obsolete, and the /dev/hd* naming scheme is from the old IDE subsystem removed in kernel 5.14. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The home= boot option was deprecated and its handler was removed from grml-autoconfig. The option silently does nothing, so remove it from the documentation to avoid misleading users. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
grml-autoconfig's service_wrapper() now uses systemctl, not /etc/init.d scripts. Remove the misleading init.d path hint from the services= boot option description. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The kernel documentation was reorganized in kernel 4.10; md.txt was moved to Documentation/admin-guide/md.rst. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zeha
changed the title
zeha
changed the title
|
🐳 Docker image for this PR is available: docker pull ghcr.io/grml/grml-live:pr-501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude to review cheatcodes.txt and the grub help texts. It identified some low-hanging fruits. See below for a list, and also for some things that need discussion / deeper investigation.
I do not propose to merge this as is, as some changes need a deeper review and also the alignment is all fucked.
#296
LLM-generated Summary
Review and update outdated information in
grml-cheatcodes.txtandboot/grub/help/*.txt.Each change is a separate commit with a reason in the commit message.
cheatcodes.txt changes
Logival→Logicalin thelvmboot option descriptionhttp://grml.organdhttp://wiki.grml.orgURLs now use HTTPSservices={espeakup,portmap,...}now usesrpcbindisofrom=filesystem prefix example now usesext4instead ofreiserfs-Hflag is deprecated in current mkpasswd (whois package) in favor of-m, and md5 password hashes are insecure. Updated tomkpasswd -m sha-512. Also removed the(available in Grml >=2013.09)note/dev/hd*device naming scheme is from the old IDE subsystem, which was removed from the Linux kernel in version 5.14grub help changes
ide?=parameter no longer exists/dev/fd0(floppy) with/dev/sdb1and/dev/hda2(old IDE naming) with/dev/sda2inconfig.txtusage exampleshome=was deprecated and its handler was removed from grml-autoconfig (no match inautoconfig.functions). The option silently does nothingservice_wrapper()in grml-autoconfig now usessystemctldirectly, not init.d scriptsDocumentation/md.txtwas moved toDocumentation/admin-guide/md.rstin kernel 4.10Points for discussion
VNC notes
Lines 180 and 185 of
grml-cheatcodes.txtsay "[Note: Grml 2011.12+ doesn't include a VNC server.]" and "[Note: Grml 2011.12+ doesn't include a VNC client.]". However,x11vncis listed inconfig/package_config/GRML_FULL, andconfig_vnc()inautoconfig.functionsactively uses it. These notes appear to be outdated — orx11vncwas re-added at some point after 2011.12. Worth investigating whether the notes should be removed or updated, and whether vnc_connect (which usesvncviewer) actually works.read-only boot option and modern device types
The
read-onlydescription now says/dev/sd*only. This should be investigated: does the actual implementation also cover/dev/mmcblk*(eMMC/SD cards) and/dev/nvme*(NVMe) devices? If not, it probably should, and the documentation should reflect whatever the implementation does.wiki.grml.org tips link
The multiboot USB pen link (
https://wiki.grml.org/doku.php?id=tips#multiboot_usb_pen) may not be stable long-term. It could be worth replacing this with a link to the actual tips/documentation on grml.org proper, but that would need stable, non-wiki URLs to point to first.Right-alignment in grub help
Some of the edits in
boot/grub/help/cheatcodes.txtbreak the right-alignment pattern that some (but not all) of the original lines followed. The file was already inconsistent in this regard. Worth deciding whether to enforce consistent alignment across the file or accept the current state.portmap debconf entry
config/debconf/GRMLBASEstill contains aportmap portmap/loopback boolean falseentry (line 7). This may be dead config if portmap is no longer installed, or it may be provided by rpcbind's compatibility layer. Worth checking separately.🤖 Generated with Claude Code