Conversation
dwerner
approved these changes
Feb 5, 2026
We used to use hardcoded POIs which required us to use fixed block hashes. But since commit f145736 that's no longer needed and we can just use whatever block hashes the chain has, making the test setup less fragile.
Instead of mining a block every 2s, mine blocks only on demand, simplifying the setup and making it much nicer to keep anvil state for future runs
This just adds a lot of unnecessary noise to the CI logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of mining a block every 2s, mine blocks only on demand, simplifying the setup and making it much nicer to keep anvil state for future runs