fix: close all xfails, resolve review findings, remove prek overlay#1
Open
wgordon17 wants to merge 1 commit intogordon-code:mainfrom
Open
fix: close all xfails, resolve review findings, remove prek overlay#1wgordon17 wants to merge 1 commit intogordon-code:mainfrom
wgordon17 wants to merge 1 commit intogordon-code:mainfrom
Conversation
- Close 5 xfail tests: prek lint (TAB indent, trailing newline, branch checkout), cog verify (conventional commits), copier update (--answers-file) - Redesign install recipe: commit before hooks, fix cog scope syntax - Remove 44-line prek binary-fetch overlay (nixpkgs is v0.3.4) - Vendor cog-schema.json locally, disable CI telemetry - Conditional README quickstart via includes/ fragment - Add just update recipe, tighten hosting_org validator per-platform - Extend Renovate fileMatch to includes/*.jinja (GR5) - Fix nix fmt stdin, migrate tests to session fixtures, rewrite derivation test
wgordon17
force-pushed
the
fix/close-xfails-and-review-findings
branch
from
fbea2c4 to
092f58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
67 tests pass, 0 xfail. Behavioral integration test passes.