fix(scanners): review findings — default audio, TCC errno, extension map#2
Merged
wgordon17 merged 1 commit intogordon-code:mainfrom Mar 9, 2026
Merged
Conversation
- Use coreaudio_default_audio_output_device marker to identify actual default audio device instead of assuming first-in-list - Add TCC errno distinction to read_launchd_plists for consistency with read_plist_safe (EPERM→DEBUG, EACCES→WARNING) - Clarify _parse_xml_dict loop condition (i+1 < len, not len-1) - Add YAML and XML to ConfigFileType enum and _EXTENSION_MAP - Remove _MAX_FILE_SIZE skip — hash_file already caps at 64KB, the size check was silently dropping entries from results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coreaudio_default_audio_output_devicemarker to identify actual default audio device instead of assuming first-in-listread_launchd_plistsfor consistency withread_plist_safe(EPERM→DEBUG, EACCES→WARNING)_parse_xml_dictloop conditionConfigFileTypeenum and_EXTENSION_MAP_MAX_FILE_SIZEskip —hash_filealready caps at 64KB, the size check was silently dropping entries from results