Implementation for removeAttendee with the beginnings of a test. by jcul22 · Pull Request #50 · googleinterns/step29-2020

jcul22 · 2020-08-07T16:40:20Z

No description provided.

Taniecer · 2020-08-07T17:00:12Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

-    public void deleteInactiveAttendees() {
-        throw new RuntimeException("Unimplemented");
+    public void deleteInactiveAttendees(DatastoreClientInterface datastore, String sessionId) { 
+        List<Attendee> attendees = datastore.getAttendeesInSession(sessionId);


getAttendeesInSession returns List

of AttendeeInterface i believe

Taniecer · 2020-08-07T17:01:25Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+        List<Attendee> attendees = datastore.getAttendeesInSession(sessionId);
+        for(int i = 0; i <= attendees.length(); i++){
+            AttendeeInterface currentAttendee = attendees.get(i);
+            AttendeeeInterface screenName = currentAttendee.getScreenName();


String screenName

Taniecer · 2020-08-07T17:02:22Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+            long currentTime = System.currentMillis(); 
+            long twoMins = 120000;
+            if(currentTime - timePolled > twoMins){
+                datastore.deleteAttendee(screenName);


deleteAttendee take screenName and sessionId

ckdesir

Pending

ckdesir · 2020-08-07T17:01:21Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+                datastore.deleteAttendee(screenName);
+            }
+
+        }


some weird formatting

ckdesir · 2020-08-07T17:01:49Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+        List<Attendee> attendees = datastore.getAttendeesInSession(sessionId);
+        for(int i = 0; i <= attendees.length(); i++){
+            AttendeeInterface currentAttendee = attendees.get(i);
+            AttendeeeInterface screenName = currentAttendee.getScreenName();


the type of screenName is a string

ckdesir · 2020-08-07T17:05:16Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+        for(int i = 0; i <= attendees.length(); i++){
+            AttendeeInterface currentAttendee = attendees.get(i);
+            AttendeeeInterface screenName = currentAttendee.getScreenName();
+            long timePolled = currentAttendee.getTimePolled();


specify the units here, add Ms (I think they are in milliseconds?) to the ends of these long times

Also I think you want currentAttendee.getTimePolled().getTime();

ckdesir

anith

Taniecer · 2020-08-07T17:05:46Z

src/test/java/com/google/sps/data/BackgroundTaskManagerTest.java

  new LocalServiceTestHelper(new LocalDatastoreServiceTestConfig());
+  BackgroundTaskManagerInterface backgroundManager = new BackgroundTaskManager(); 
+  private final DatastoreClientInterface datastore = new DatastoreClient();  
+  String sessionId = "12345";  


Create test data in each individual test

ckdesir · 2020-08-07T17:06:42Z

src/test/java/com/google/sps/data/BackgroundTaskManagerTest.java

+  datastore.insertOrUpdateAttendee(attendee);
+  datastore.insertOrUpdateAttendee(attendee2);
+  datastore.insertOrUpdateAttendee(attendee3);
+


some formatting issues here as well

ckdesir · 2020-08-07T17:10:18Z

src/test/java/com/google/sps/data/BackgroundTaskManagerTest.java

+    backgroundManager.deleteInactiveAttendees(datastore,sessionId);
+    Assert.assertEquals(datastore.getAttendeesInSession, {"Taniece", "Chris"});


does this work?

also i think you reversed this, you expect "Taniece" and "Chris" but you actually get datastore.getAttendeesInSession(parameters)

ckdesir

pending

Taniecer · 2020-08-07T17:14:48Z

src/test/java/com/google/sps/data/BackgroundTaskManagerTest.java

+  BackgroundTaskManagerInterface backgroundManager = new BackgroundTaskManager(); 
+  private final DatastoreClientInterface datastore = new DatastoreClient();  
+  String sessionId = "12345";  
+  long date = 239201;


date should be of type Date()

https://www.geeksforgeeks.org/program-to-convert-milliseconds-to-a-date-format-in-java/

chukwuemekagooglecorp

Pending

Some of this code doesn't compile and has syntax errors.
Run "mvn test" in the test directory to expose the errors and then fix them before putting out a PR.

chukwuemekagooglecorp · 2020-08-07T23:00:11Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

-        throw new RuntimeException("Unimplemented");
+    public void deleteInactiveAttendees(DatastoreClientInterface datastore, String sessionId) { 
+        List<Attendee> attendees = datastore.getAttendeesInSession(sessionId);
+        for(int i = 0; i <= attendees.length(); i++){


I think this produces an IndexOutOfBoundsException. I think you want "i < attendees.size()"

chukwuemekagooglecorp · 2020-08-07T23:00:41Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+        for(int i = 0; i <= attendees.length(); i++){
+            AttendeeInterface currentAttendee = attendees.get(i);
+            AttendeeeInterface screenName = currentAttendee.getScreenName();
+            long timePolled = currentAttendee.getTimePolled();


Also I think you want currentAttendee.getTimePolled().getTime();

chukwuemekagooglecorp · 2020-08-07T23:04:01Z

src/main/java/com/google/sps/data/BackgroundTaskManager.java

+            AttendeeeInterface screenName = currentAttendee.getScreenName();
+            long timePolled = currentAttendee.getTimePolled();
+            long currentTime = System.currentMillis(); 
+            long twoMins = 120000;


Create a constant at the top of the class:

// If an attendee last polled the server longer this amount of time ago, we assume the attendee
// left and we delete them from the database. < --- use appropriate javadoc format for this comment
private static final LAST_TIME_POLLED_DEADLINE_MS = 2 * 60 * 1000; // 2 minutes

Implementation for removeAttendee with the beginnings of a test.

e83e1b2

jcul22 requested review from Sarsate, Taniecer, chukwuemekagooglecorp and ckdesir August 7, 2020 16:40

Taniecer reviewed Aug 7, 2020

View reviewed changes

ckdesir reviewed Aug 7, 2020

View reviewed changes

Taniecer reviewed Aug 7, 2020

View reviewed changes

ckdesir reviewed Aug 7, 2020

View reviewed changes

Taniecer reviewed Aug 7, 2020

View reviewed changes

chukwuemekagooglecorp suggested changes Aug 7, 2020

View reviewed changes

		backgroundManager.deleteInactiveAttendees(datastore,sessionId);
		Assert.assertEquals(datastore.getAttendeesInSession, {"Taniece", "Chris"});

Conversation

jcul22 commented Aug 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckdesir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckdesir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckdesir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chukwuemekagooglecorp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants