-
Notifications
You must be signed in to change notification settings - Fork 86
chore: librarian update image pull request: 20260219T183840Z #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ | |
| from google.cloud.firestore_admin_v1.types import schedule | ||
| from google.cloud.firestore_admin_v1.types import user_creds | ||
| from google.cloud.firestore_admin_v1.types import user_creds as gfa_user_creds | ||
| from google.protobuf import empty_pb2 # type: ignore | ||
| import google.protobuf.empty_pb2 as empty_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
|
|
||
|
|
||
|
|
@@ -2105,7 +2105,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -2257,7 +2257,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -2569,7 +2569,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -2721,7 +2721,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3014,7 +3014,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3124,7 +3124,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3238,7 +3238,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3377,7 +3377,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3486,7 +3486,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -3913,7 +3913,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -4970,7 +4970,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -6175,7 +6175,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -6487,7 +6487,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
@@ -6639,7 +6639,7 @@ def __call__( | |
| ) | ||
| method = transcoded_request["method"] | ||
| try: | ||
| request_payload = json_format.MessageToJson(request) | ||
| request_payload = type(request).to_json(request) | ||
| except: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| request_payload = None | ||
| http_request = { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a bare
except:clause is generally discouraged as it can catch unexpected exceptions likeSystemExitorKeyboardInterrupt. It's better to catch a more specific exception, likeException.