chore: librarian update image pull request: 20260219T182100Z

[parthea]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:a38add811f7f139d6a385b22d283ad09ef305b8cf50382ef62f0ce690787f021

Generation failed for

• google-cloud-firestore

[parthea]

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

[gemini-code-assist]

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the python-librarian-generator image, which is responsible for generating client libraries. The image update led to substantial changes within the google-cloud-firestore library, resulting in the removal of numerous files across its admin, bundle, and core v1 modules. Concurrently, a Python script used in the generation process was adjusted to align with new import paths for Firestore types. The PR description notes that generation failed for google-cloud-firestore, which likely explains the extensive removals and refactoring seen in the diff.

Highlights

• Librarian Image Update: The python-librarian-generator Docker image has been updated to a new SHA256 hash, indicating a new version of the code generation tool.
• Firestore Client Library Refactoring/Removal: A significant number of files related to the google-cloud-firestore client library, including admin, bundle, and core v1 components, have been removed. This suggests a major restructuring or deprecation of these specific client library parts, possibly due to the updated generator.
• Python Import Path Updates: A Python script (.librarian/generator-input/librarian.py) was modified to update import statements for Firestore document and query protobufs, changing from google.firestore.v1 to google.cloud.firestore_v1.types.

Changelog

• .librarian/generator-input/librarian.py
  • Updated import statements for document_pb2 and query_pb2 to use google.cloud.firestore_v1.types.
• .librarian/state.yaml
  • Updated the image SHA256 hash for the python-librarian-generator.
• docs/README.rst
  • Removed the entire file, which contained documentation for the Python Client for Cloud Firestore API.
• docs/summary_overview.md
  • Removed the entire file, which contained an overview of Firestore API entries.
• google/cloud/firestore_admin_v1/gapic_metadata.json
  • Removed the GAPIC metadata file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/gapic_version.py
  • Removed the version file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/py.typed
  • Removed the PEP 561 marker file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/services/init.py
  • Removed the __init__.py file for firestore_admin_v1 services.
• google/cloud/firestore_admin_v1/services/firestore_admin/init.py
  • Removed the __init__.py file for firestore_admin service.
• google/cloud/firestore_admin_v1/services/firestore_admin/pagers.py
  • Removed the pagers file for firestore_admin.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/README.rst
  • Removed the transport README for firestore_admin.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/init.py
  • Removed the __init__.py file for firestore_admin transports.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/base.py
  • Removed the base transport file for firestore_admin.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/grpc.py
  • Removed the gRPC transport file for firestore_admin.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/grpc_asyncio.py
  • Removed the gRPC asyncio transport file for firestore_admin.
• google/cloud/firestore_admin_v1/services/firestore_admin/transports/rest_base.py
  • Removed the REST base transport file for firestore_admin.
• google/cloud/firestore_admin_v1/types/init.py
  • Removed the __init__.py file for firestore_admin_v1 types.
• google/cloud/firestore_admin_v1/types/backup.py
  • Removed the backup types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/database.py
  • Removed the database types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/field.py
  • Removed the field types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/firestore_admin.py
  • Removed the core firestore_admin types file.
• google/cloud/firestore_admin_v1/types/index.py
  • Removed the index types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/location.py
  • Removed the location types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/operation.py
  • Removed the operation types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/realtime_updates.py
  • Removed the realtime updates types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/schedule.py
  • Removed the schedule types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/snapshot.py
  • Removed the snapshot types file for firestore_admin_v1.
• google/cloud/firestore_admin_v1/types/user_creds.py
  • Removed the user creds types file for firestore_admin_v1.
• google/cloud/firestore_bundle/init.py
  • Removed the __init__.py file for firestore_bundle.
• google/cloud/firestore_bundle/gapic_metadata.json
  • Removed the GAPIC metadata file for firestore_bundle.
• google/cloud/firestore_bundle/gapic_version.py
  • Removed the version file for firestore_bundle.
• google/cloud/firestore_bundle/py.typed
  • Removed the PEP 561 marker file for firestore_bundle.
• google/cloud/firestore_bundle/services/init.py
  • Removed the __init__.py file for firestore_bundle services.
• google/cloud/firestore_bundle/types/init.py
  • Removed the __init__.py file for firestore_bundle types.
• google/cloud/firestore_bundle/types/bundle.py
  • Removed the bundle types file for firestore_bundle.
• google/cloud/firestore_v1/gapic_metadata.json
  • Removed the GAPIC metadata file for firestore_v1.
• google/cloud/firestore_v1/gapic_version.py
  • Removed the version file for firestore_v1.
• google/cloud/firestore_v1/py.typed
  • Removed the PEP 561 marker file for firestore_v1.
• google/cloud/firestore_v1/services/init.py
  • Removed the __init__.py file for firestore_v1 services.
• google/cloud/firestore_v1/services/firestore/init.py
  • Removed the __init__.py file for firestore service.
• google/cloud/firestore_v1/services/firestore/async_client.py
  • Removed the async client file for firestore.
• google/cloud/firestore_v1/services/firestore/pagers.py
  • Removed the pagers file for firestore.
• google/cloud/firestore_v1/services/firestore/transports/README.rst
  • Removed the transport README for firestore.
• google/cloud/firestore_v1/services/firestore/transports/init.py
  • Removed the __init__.py file for firestore transports.
• google/cloud/firestore_v1/services/firestore/transports/base.py
  • Removed the base transport file for firestore.
• google/cloud/firestore_v1/services/firestore/transports/grpc.py
  • Removed the gRPC transport file for firestore.
• google/cloud/firestore_v1/services/firestore/transports/grpc_asyncio.py
  • Removed the gRPC asyncio transport file for firestore.
• google/cloud/firestore_v1/services/firestore/transports/rest_base.py
  • Removed the REST base transport file for firestore.
• google/cloud/firestore_v1/types/init.py
  • Removed the __init__.py file for firestore_v1 types.
• google/cloud/firestore_v1/types/aggregation_result.py
  • Removed the aggregation result types file for firestore_v1.
• google/cloud/firestore_v1/types/bloom_filter.py
  • Removed the bloom filter types file for firestore_v1.
• google/cloud/firestore_v1/types/common.py
  • Removed the common types file for firestore_v1.
• google/cloud/firestore_v1/types/document.py
  • Removed the document types file for firestore_v1.
• google/cloud/firestore_v1/types/explain_stats.py
  • Removed the explain stats types file for firestore_v1.

Activity

• The pull request was opened by parthea.
• The pull request description indicates an automated librarian image update.
• The description also explicitly states that 'Generation failed for - google-cloud-firestore', which likely led to the extensive removal of files related to this library.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the generator image and fixup scripts, but it also results in the catastrophic deletion of nearly all source files for the Firestore library (including firestore_v1, firestore_admin_v1, and firestore_bundle). This is consistent with the 'Generation failed' note in the PR description. Merging this would effectively remove the library from the repository. This PR should not be merged until the generation process is fixed and the source files are correctly restored.

I am having trouble creating individual review comments. Click here to see my feedback.

.librarian/state.yaml (1)

The update to this generator image hash is associated with a failed generation run that is deleting the entire Firestore library. This change should not be committed until the generation failure is resolved and the source code is correctly preserved.

google/cloud/firestore_v1/services/firestore/async_client.py (1-2310)

This file, along with the rest of the library's source code, is being deleted. This is a catastrophic change that appears to be an unintended consequence of the generation failure mentioned in the PR description. The PR should be blocked until the generator can successfully produce the library code.