Skip to content

chore(preview): trim down legacylibrarian configs#15578

Draft
noahdietz wants to merge 1 commit intogoogleapis:previewfrom
noahdietz:preview-legacylibrarian-minimization
Draft

chore(preview): trim down legacylibrarian configs#15578
noahdietz wants to merge 1 commit intogoogleapis:previewfrom
noahdietz:preview-legacylibrarian-minimization

Conversation

@noahdietz
Copy link
Contributor

Reduces the .librarian/state.yaml and .librarian/generator-input/client-post-processing content to what is necessary for our initial client on the preview branch.

Discussed internally here.

Ran local generation against preview branch of googleapis successfully.

http://b/450631301

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant cleanup of the legacylibrarian configuration files, specifically within the generator-input/client-post-processing directory. By removing a large number of these configuration files, the PR aims to streamline the setup and generation process for the initial client on the preview branch, ensuring that only essential configurations are maintained.

Highlights

  • Configuration Cleanup: Numerous legacylibrarian client post-processing configuration files have been removed from the .librarian/generator-input/client-post-processing directory.
  • Streamlined Generation: The .librarian directory content has been trimmed down to only what is necessary for the initial client on the preview branch, simplifying the configuration.
  • Successful Local Generation: Local generation against the preview branch of googleapis was successfully run after these configuration changes.
Changelog
  • .librarian/generator-input/client-post-processing/add-dependency-google-cloud-common.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/add-missing-dependencies-to-setup-py-constraints.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/allow-docs-warnings-for-google-shopping-merchant-accounts.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/bigquery-storage-integration.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/containeranalysis-grafeas-integration.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/doc-formatting.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/docs-index-rst-for-unversioned-apis.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/integrate-isolated-handwritten-code.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/mypy-error-with-org-policy-as-dependency.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/proto-plus-dependency-with-modified-namespace.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/remove-unused-imports.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/revert-reserved-words.yaml
    • Removed the configuration file.
  • .librarian/generator-input/client-post-processing/sub-api-versioned-namespace.yaml
    • Removed the configuration file.
Activity
  • Internal discussions were held regarding these configuration changes, as referenced by a Google Docs link.
  • Local generation was successfully run against the preview branch of googleapis to validate the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a cleanup effort to reduce legacy librarian configurations for the preview branch. It removes a number of YAML files from the .librarian/generator-input/client-post-processing directory. The changes are consistent with the pull request's goal of trimming down content to what is necessary for the initial client. The file deletions look appropriate and I see no issues with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments