This repository was archived by the owner on Aug 25, 2025. It is now read-only.
[Feat] [Issue-185] do not use global variables for all wire.Value expressions#397
Open
ProgrammingMuffin wants to merge 8 commits intogoogle:mainfrom
Open
[Feat] [Issue-185] do not use global variables for all wire.Value expressions#397ProgrammingMuffin wants to merge 8 commits intogoogle:mainfrom
ProgrammingMuffin wants to merge 8 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
testdata/VarValue fails due to program output related problems. This might be that one edge case where the replaced value is wrong. |
ProgrammingMuffin
changed the title
Author
|
@zombiezen could you please take a look at this PR? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue-185
Previously, wire used to generate global variables and inject them in place of
wire.Value(..)but now it won't create global variables at all and instead puts the value directly from source.Source:
Generated:
