Reduce the number of scope expansions during overlapped file detection in Version::GetOverlappingInputs#1268
Open
caelumable wants to merge 1 commit intogoogle:mainfrom
Open
Reduce the number of scope expansions during overlapped file detection in Version::GetOverlappingInputs#1268caelumable wants to merge 1 commit intogoogle:mainfrom
caelumable wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the range of user_begin and user_end is
[c, d]while the range of file_start and file_limit is[a, g], this would result in two scope expansions: first expanding user_begin and user_end to [a, d], and then further expanding them to [a, g], thereby increasing the number of loop iterations.Removing this
elseclause would allow completing the scope expansion in a single step by directly adjusting user_begin and user_end to [a, g].