Fix null pointer deref in FRAME_BUILTIN_FORCE_THUNKS impl#1307
Merged
johnbartholomew merged 1 commit intogoogle:masterfrom Mar 13, 2026
Merged
Conversation
Since google#1299 there is a code-path which constructs a `FRAME_BUILTIN_FORCE_THUNKS` Frame with `nullptr` `ast`. Somehow this did not cause crashes in the test suite (until it was run with a more hardened build)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1299 there is a code-path which constructs a
FRAME_BUILTIN_FORCE_THUNKSFrame withnullptrast.Somehow this did not cause crashes in the test suite (until it was run with a more hardened build)