Migrate MultipleChoiceTaskFragment to use TaskScreen Component#3652
Open
shobhitagarwal1612 wants to merge 2 commits intomasterfrom
Open
Migrate MultipleChoiceTaskFragment to use TaskScreen Component#3652shobhitagarwal1612 wants to merge 2 commits intomasterfrom
shobhitagarwal1612 wants to merge 2 commits intomasterfrom
Conversation
…screen - Extract the multiple-choice task UI into a new `MultipleChoiceTaskScreen` Composable. - Migrate `MultipleChoiceTaskFragment` to use `createComposeView`, integrating `MultipleChoiceTaskScreen` for rendering. - Update the fragment to delegate action handling and footer position updates to the new screen component. - Move the task body rendering logic from `MultipleChoiceTaskFragment` to `MultipleChoiceTaskContent`. - Replace `MultipleChoiceTaskFragmentTest` with `MultipleChoiceTaskScreenTest`, migrating tests to use `composeTestRule`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3652 +/- ##
============================================
- Coverage 66.80% 66.72% -0.08%
+ Complexity 1631 1625 -6
============================================
Files 362 363 +1
Lines 8939 8957 +18
Branches 1144 1147 +3
============================================
+ Hits 5972 5977 +5
- Misses 2320 2329 +9
- Partials 647 651 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3630
MultipleChoiceTaskScreenComposable to handle the UI.MultipleChoiceTaskFragmentto usecreateComposeViewand render the newMultipleChoiceTaskScreen.MultipleChoiceTaskFragmentTestwithMultipleChoiceTaskScreenTestand add more coverageThere is a pure refactor and doesn't cause any visual change.
@andreia-ferreira PTAL?