Fix crash on draw area task#3646
Merged
shobhitagarwal1612 merged 2 commits intomasterfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3646 +/- ##
=========================================
Coverage 66.85% 66.85%
+ Complexity 1656 1655 -1
=========================================
Files 357 357
Lines 8803 8802 -1
Branches 1121 1120 -1
=========================================
Hits 5885 5885
+ Misses 2279 2278 -1
Partials 639 639
🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DrawAreaTaskFragmentdeclared alateinit var drawAreaTaskMapFragmentthat is now never assigned. This is because the framgent is now created internally byTaskMapFragmentContainer. When the camera movements were collected from the VM, it tried to callmoveToPosition()on the uninitialized reference and this caused a crash.This is easily fixed by moving the collection of
cameraMoveEventstoDrawAreaTaskMapFragmentas this is the place where most of the other flows are being collected anyway@shobhitagarwal1612 PTAL?