Add TaskScreen for creating compose based UI for tasks#3642
Merged
shobhitagarwal1612 merged 21 commits intomasterfrom Mar 30, 2026
Merged
Add TaskScreen for creating compose based UI for tasks#3642shobhitagarwal1612 merged 21 commits intomasterfrom
TaskScreen for creating compose based UI for tasks#3642shobhitagarwal1612 merged 21 commits intomasterfrom
Conversation
Removed the setLoiName function to simplify state management.
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3642 +/- ##
============================================
- Coverage 66.78% 0 -66.79%
============================================
Files 354 0 -354
Lines 8781 0 -8781
Branches 1108 0 -1108
============================================
- Hits 5864 0 -5864
+ Misses 2281 0 -2281
+ Partials 636 0 -636 🚀 New features to boost your workflow:
|
Member
Author
|
@andreia-ferreira PTAL? |
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/TaskScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/TaskScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/TaskScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/TaskScreenState.kt
Outdated
Show resolved
Hide resolved
The issue occurred because Google Maps loads asynchronously, and its listeners can fire even when the Fragment's view is being destroyed. If the user navigated away from the fragment before getMapAsync finished, onMapReady() would attempt to access viewLifecycleOwner when the fragment's view was already null (after onDestroyView()).
Member
Author
|
@andreia-ferreira Applied all changes. Ready for another pass! |
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
shobhitagarwal1612
changed the title
TaskScreen for creating compose based UI for tasks
shobhitagarwal1612
changed the title
TaskScreen for creating compose based UI for tasksTaskScreen for creating compose based UI for tasks
shobhitagarwal1612
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
shobhitagarwal1612
requested review from
andreia-ferreira
and removed request for
hassan-nsubuga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3630
Split from #3635
Things done:
TaskScreenwhich aims to move the logic for building layout from Fragment to compose. This will be used for creating tasks in follow up PRs.@andreia-ferreira PTAL?