Merged
Conversation
Collaborator
Author
|
Needs llvm/llvm-project#183469 to pass |
rjodinchr
force-pushed
the
update-llvm
branch
from
d5f6b25 to
2400f37
Compare
rjodinchr
force-pushed
the
update-llvm
branch
from
2400f37 to
09081db
Compare
dneto0
approved these changes
Feb 26, 2026
| // CHECK: %[[printf_buffer_access:[0-9a-zA-Z_]+]] = OpAccessChain %{{[0-9a-zA-Z_]+}} %[[printf_buffer]] %[[zero]] %[[zero]] | ||
| // CHECK: %[[printf_offset:[0-9a-zA-Z_]+]] = OpAtomicIAdd %[[uint]] %[[printf_buffer_access]] %{{[0-9a-zA-Z_]+}} %{{[0-9a-zA-Z_]+}} %[[one]] | ||
| // CHECK: %[[printf_st_offset:[0-9a-zA-Z_]+]] = OpIAdd %[[uint]] %[[printf_offset]] %[[one]] | ||
| // CHECK: %[[printf_st_offset:[0-9a-zA-Z_]+]] = OpIAdd %[[uint]] %[[one]] %[[printf_offset]] |
Collaborator
There was a problem hiding this comment.
oh fun. i wonder why the order changed. (But not that much)
| auto initializer = GV->getInitializer(); | ||
| if (initializer && !initializer->isOneValue() && | ||
| !initializer->isNullValue() && !initializer->isZeroValue() && | ||
| !initializer->isNullValue() && !initializer->isNullValue() && |
Collaborator
There was a problem hiding this comment.
this is now redundant, but ok to land
| initializer = Constant::getAllOnesValue(Ty); | ||
| } else if (initializer && | ||
| (initializer->isNullValue() || initializer->isZeroValue())) { | ||
| (initializer->isNullValue() || initializer->isNullValue())) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.