fix(fw_cfg): clear ACPI table checksums before recalculation#417
Merged
Lencerf merged 1 commit intogoogle:mainfrom Mar 6, 2026
Merged
fix(fw_cfg): clear ACPI table checksums before recalculation#417Lencerf merged 1 commit intogoogle:mainfrom
Lencerf merged 1 commit intogoogle:mainfrom
Conversation
The fw_cfg `ADD_CHECKSUM` command includes the checksum field itself when calculating the new checksum for an ACPI table. If the checksum is not cleared beforehand, this results in an incorrect final checksum. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Pull Request Test Coverage Report for Build 22752951058Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fw_cfg
ADD_CHECKSUMcommand includes the checksum field itself when calculating the new checksum for an ACPI table. If the checksum is not cleared beforehand, this results in an incorrect final checksum.