feat: dark-mode carousel code blocks, Linear connector demo, icon fixes#395
Merged
steve-calvert-glean merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
…dering fixes - Replace Docusaurus CodeBlock with prism-react-renderer Highlight + themes.dracula in carousel slides, forcing dark mode regardless of site theme toggle - Add LinearConnector code sample (glean-indexing-sdk) to "Bring Every Data Source" carousel slide — shows BaseDatasourceConnector pattern with real connector fields - Constrain carousel code panels with max-height + overflow to prevent height blowout - Fix carousel Swiper overflow: visible → hidden to stop dark gradient from bleeding into adjacent image slides during transitions - Fix GleanIcon SVG cleanup: stroke-only paths now get fill="none" instead of fill="currentColor", correcting the solid-filled wedge on the code-block icon - Fix invalid icon names in deep-linked-citations.mdx: Brain → Cpu, Sparkles → sparkles (glean iconSet) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…brand.css - Bump --ifm-heading-font-weight from 400 to 600; add weight token variables (--ifm-font-weight-medium/semibold/bold) from Glean design system - Add per-level heading rules: h2-h3 semibold, h4-h6 medium, h1 bold - Add strong/b element weight rule (semibold, matching Glean DS pattern) - Add full Glean design token set: border-radius scale (sm→2xl), shadow scale (sm→xl), semantic colors (success/warning/danger/info), brand accent palette - Add sidebar background (#f6f6f6) and dark-mode reset to match Glean product - Add admonition cleanup: remove Infima default border, apply radius token - Use --glean-border-radius-sm token in scrollbar rules Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
travis-hoover-glean
approved these changes
Mar 16, 2026
steve-calvert-glean
deleted the
feat/homepage-carousel-dark-code-icon-fixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeBlockwithprism-react-rendererHighlight+themes.draculadirectly.CodeBlockbakes inline styles at render time from the site's current theme — the only way to force dark is to pass a dark theme object at the component level.glean-indexing-sdkconnector class (LinearConnectorextendingBaseDatasourceConnector) instead of the generic SDK usage example.overflow: autoso long snippets don't blow out the slide heightoverflow: visible→hiddento prevent the dark gradient container from bleeding into adjacent image slides during autoplay transitionsGleanIconSVG cleanup was addingfill="currentColor"to ALL paths without an explicit fill attribute — including stroke-only paths, which turned them into solid filled shapes. Thecode-blockicon was rendering as a solid blue wedge instead of the</>bracket shape. Fix: paths withstroke=but nofill=now getfill="none", preserving the designer's stroke-only intent.icon="Brain"→icon="Cpu"andicon="Sparkles"→icon="sparkles" iconSet="glean"indeep-linked-citations.mdx—BrainandSparklesdon't exist in react-feather or the Glean icon manifest, causing silent empty renders.Test plan
LinearConnectorclass withBaseDatasourceConnector,CustomDatasourceConfig, andtransform()— scrollable if taller than 340px</>code-block icon, not a solid filled triangle/guides/chat/deep-linked-citationspage rendersCpuandsparklesicons correctly (no empty icon slots)🤖 Generated with Claude Code