Fixed MySQL Queries

[sananguliyev]

There are some issues with queries:

1. TEXT column can't have a default value (related to sshkeys & custattr from users table)
2. GROUPS is a reserved word in MySQL, which means we either rename the table or use between backticks (I have used backticks in order to not change any implementation)

[42wim]

You can have a default though, fixed by putting it in () custattr TEXT DEFAULT ('{}')) (https://www.drupal.org/project/drupal/issues/3232804)

[sananguliyev]

@42wim actually you're right. I missed that. It's also possible to use that.

[42wim]

I've found some other issues now btw while testing the mysql backend.
All the code where groups don't have the backticks fail, so they need also be changed

https://github.com/glauth/glauth/blob/0e7769ff841e096dbf0cb67768cbd2ab7142f6fb/v2/pkg/plugins/basesqlhandler.go#L186-L187

err = h.database.cnx.QueryRow(fmt.Sprintf(`
			SELECT g.gidnumber FROM groups g WHERE lower(name)=%s`, h.sqlBackend.GetPrepareSymbol()), groupName).Scan(

needs to become

err = h.database.cnx.QueryRow(fmt.Sprintf(`
			SELECT g.gidnumber FROM `+"`groups`"+` g WHERE lower(name)=%s`, h.sqlBackend.GetPrepareSymbol()), groupName).Scan(

I'm not sure if this has impact on postgres/sqlite

[Fusion]

Backticks may indeed causes in postgres. I'm going to check that out, good catch!

[sananguliyev]

Any update here?