Open
Conversation
|
could you update the read-me to reflect how to use this feature? |
Author
|
Because the settings and deploymentConfig objects are combined to a single object, the organization settings can override/set values that are intended to come from the deploymentConfig. This PR separates them, as this was felt to be too unsafe for this deploymentConfig setting |
Author
|
This should get rebased on top of #768. |
jonathanmorley
force-pushed
the
safe-settings/unsafe
branch
from
84ca3d5 to
5690233
Compare
jonathanmorley
force-pushed
the
safe-settings/unsafe
branch
from
5690233 to
cc3ab91
Compare
decyjphr
requested changes
Sep 25, 2025
|
|
||
| const unsafeFields = this.config.unsafeFields | ||
| if (unsafeFields) { | ||
| if (this.isIterable(unsafeFields)) { |
Collaborator
There was a problem hiding this comment.
this.isIterable(...) is not a method on this class. It used to be there but is not in this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the capability for safe-settings to treat some fields as 'unsafe', and allow them to be configured by the individual repositories.