Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR marks legacy stretch and stress methods as deprecated and enhances the implementation of the principle stretch computation.
- Deprecates old
pstretch_into,pstretchDir_into,pstress_into,pstressDir_into,parameters_into, andtransform_intoin the base class. - Introduces new
eval3D_pstretchinterface and specialized implementations for compressible and incompressible cases. - Updates include paths and removes an unused variable.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/gsThinShellUtils.h | Updated include path for gsExpressions |
| src/gsMaterialMatrixNonlinear.hpp | Added eval3D_pstretch methods and left a stray debug call to remove |
| src/gsMaterialMatrixNonlinear.h | Declared eval3D_pstretch override and its template overloads |
| src/gsMaterialMatrixBaseDim.hpp | Removed unused variable in deformation method |
| src/gsMaterialMatrixBase.h | Marked several legacy methods as GISMO_DEPRECATED |
Comments suppressed due to low confidence (2)
src/gsMaterialMatrixNonlinear.hpp:568
- New
eval3D_pstretchmethod introduces significant logic; add unit tests covering both compressible and incompressible template specializations to verify correctness.
gsMatrix<T> gsMaterialMatrixNonlinear<dim,T,matId,comp,mat,imp>::eval3D_pstretch(const index_t patch, const gsMatrix<T> & u, const gsMatrix<T> & z) const
src/gsMaterialMatrixNonlinear.hpp:220
- Stray debug statement left in production code; consider removing the
gsDebugVarcall or guarding it behind a debug flag.
gsDebugVar("AAAAA)");
hverhelst
commented
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPROVE: