Skip to content

fix(client) Align logger names with package name#572

Merged
markstory merged 4 commits intomainfrom
chore-logger-names
Mar 16, 2026
Merged

fix(client) Align logger names with package name#572
markstory merged 4 commits intomainfrom
chore-logger-names

Conversation

@markstory
Copy link
Member

I missed fixing some logger names when porting code from sentry.

Refs getsentry/launchpad#582

I missed fixing some logger names when porting code from sentry.

Refs getsentry/launchpad#582
@markstory markstory requested a review from a team as a code owner March 13, 2026 15:47
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Three worker modules now share identical logger name
    • Changed logger name in client.py to 'taskbrokerclient.worker.client' to distinguish it from worker.py and workerchild.py

Create PR

Or push these changes by commenting:

@cursor push aefe1cddbe
Preview (aefe1cddbe)
diff --git a/clients/python/src/taskbroker_client/worker/client.py b/clients/python/src/taskbroker_client/worker/client.py
--- a/clients/python/src/taskbroker_client/worker/client.py
+++ b/clients/python/src/taskbroker_client/worker/client.py
@@ -27,7 +27,7 @@
 from taskbroker_client.metrics import MetricsBackend
 from taskbroker_client.types import InflightTaskActivation, ProcessingResult
 
-logger = logging.getLogger("taskbrokerclient.worker")
+logger = logging.getLogger("taskbrokerclient.worker.client")
 
 MAX_ACTIVATION_SIZE = 1024 * 1024 * 10
 """Max payload size we will process."""

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

from taskbroker_client.task import Task

logger = logging.getLogger("taskworker.scheduler")
logger = logging.getLogger("taskbrokerclient.scheduler")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use __name__?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the shorter module names were simpler. I can switch to __name__ though as it is a convention we use more often.

@markstory markstory merged commit f4880d1 into main Mar 16, 2026
33 of 34 checks passed
@markstory markstory deleted the chore-logger-names branch March 16, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants