fix(client) Align logger names with package name#572
Merged
Conversation
I missed fixing some logger names when porting code from sentry. Refs getsentry/launchpad#582
evanh
approved these changes
Mar 13, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Three worker modules now share identical logger name
- Changed logger name in client.py to 'taskbrokerclient.worker.client' to distinguish it from worker.py and workerchild.py
Or push these changes by commenting:
@cursor push aefe1cddbe
Preview (aefe1cddbe)
diff --git a/clients/python/src/taskbroker_client/worker/client.py b/clients/python/src/taskbroker_client/worker/client.py
--- a/clients/python/src/taskbroker_client/worker/client.py
+++ b/clients/python/src/taskbroker_client/worker/client.py
@@ -27,7 +27,7 @@
from taskbroker_client.metrics import MetricsBackend
from taskbroker_client.types import InflightTaskActivation, ProcessingResult
-logger = logging.getLogger("taskbrokerclient.worker")
+logger = logging.getLogger("taskbrokerclient.worker.client")
MAX_ACTIVATION_SIZE = 1024 * 1024 * 10
"""Max payload size we will process."""This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
untitaker
approved these changes
Mar 16, 2026
| from taskbroker_client.task import Task | ||
|
|
||
| logger = logging.getLogger("taskworker.scheduler") | ||
| logger = logging.getLogger("taskbrokerclient.scheduler") |
Member
Author
There was a problem hiding this comment.
I thought the shorter module names were simpler. I can switch to __name__ though as it is a convention we use more often.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I missed fixing some logger names when porting code from sentry.
Refs getsentry/launchpad#582