Skip to content

add optional font inlining to presentation creator#88

Open
shellmayr wants to merge 1 commit intomainfrom
shellmayr/add-offline-fonts-to-presentation-creator
Open

add optional font inlining to presentation creator#88
shellmayr wants to merge 1 commit intomainfrom
shellmayr/add-offline-fonts-to-presentation-creator

Conversation

@shellmayr
Copy link
Member

Add a description for how to inline fonts into the HTML as an optional feature to the presentation creator

@shellmayr shellmayr requested a review from HazAT March 9, 2026 15:53
Comment on lines +20 to +24
import '@fontsource/rubik/500.css'
import '@fontsource/rubik/600.css'
import '@fontsource/rubik/700.css'
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The documentation for creating offline presentations fails to instruct the removal of the Material Symbols font link, resulting in a build that is not fully self-contained.
Severity: MEDIUM

Suggested Fix

Update Step 3 in offline-fonts.md to explicitly show the removal of both the Rubik and Material Symbols font links. Alternatively, add a note in Step 3 clarifying that the Material Symbols link must also be removed and reference the dedicated section that recommends replacing the font with SVGs or Unicode symbols for a truly offline build.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
plugins/sentry-skills/skills/presentation-creator/references/offline-fonts.md#L20-L24

Potential issue: The new documentation in `offline-fonts.md` for creating self-contained
presentations is incomplete. The instructions in Step 3, titled "Remove Google Fonts
links," only show the removal of the `Rubik` font link. It fails to instruct the user to
also remove the link for `Material Symbols`. If a user follows the steps literally, the
resulting presentation will not be fully self-contained as claimed. It will still
attempt to make a network request to Google Fonts to load the `Material Symbols` font,
which will fail in an offline environment, causing icons to not render correctly.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant