add optional font inlining to presentation creator#88
Open
Conversation
Comment on lines
+20
to
+24
| import '@fontsource/rubik/500.css' | ||
| import '@fontsource/rubik/600.css' | ||
| import '@fontsource/rubik/700.css' | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Bug: The documentation for creating offline presentations fails to instruct the removal of the Material Symbols font link, resulting in a build that is not fully self-contained.
Severity: MEDIUM
Suggested Fix
Update Step 3 in offline-fonts.md to explicitly show the removal of both the Rubik and Material Symbols font links. Alternatively, add a note in Step 3 clarifying that the Material Symbols link must also be removed and reference the dedicated section that recommends replacing the font with SVGs or Unicode symbols for a truly offline build.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
plugins/sentry-skills/skills/presentation-creator/references/offline-fonts.md#L20-L24
Potential issue: The new documentation in `offline-fonts.md` for creating self-contained
presentations is incomplete. The instructions in Step 3, titled "Remove Google Fonts
links," only show the removal of the `Rubik` font link. It fails to instruct the user to
also remove the link for `Material Symbols`. If a user follows the steps literally, the
resulting presentation will not be fully self-contained as claimed. It will still
attempt to make a network request to Google Fonts to load the `Material Symbols` font,
which will fail in an offline environment, causing icons to not render correctly.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a description for how to inline fonts into the HTML as an optional feature to the presentation creator