-
-
Notifications
You must be signed in to change notification settings - Fork 176
ref(cargo): Extract common items to workspace #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c203754 to
40651f8
Compare
|
I assume it will also not accept the shorthand: There is an issue in the Not familiar overall with the release process etc, but your suggestion also makes sense to me. |
imho it would be simplest just to keep the |
I will double-check this |
Totally fair! |
|
@Dav1dde Also I just reread your comment, and noticed you were mentioning workspace dependencies. This change does not extract dependencies to the workspace yet, only the package items. |
f6e6081 to
44de6e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
44de6e8 to
601a145
Compare
Bump the MSRV to 1.88 to allow dependency updates (see #968). I do not think this change requires a major version bump, as our [MSRV policy](https://github.com/getsentry/sentry-rust?tab=readme-ov-file#requirements) states we try to support the last six months of Rust versions, and 1.88 is more than six months old. Stacked on #969.
Extract all common package items, which can be extracted, to the workspace
Cargo.toml, except for theversionfield.Note on
version&licenseWe cannot extract
versionbecause it causes a parse error when generating the crateREADME.mdfiles while bumping the version prior to release, as thecargo-readmetool we use to generate these files apparently cannot parseversion = { workspace = true }, as it expects version to be set to a string. Similarly,cargo readmealso fails iflicenseis set with{ workspace = true }@Dav1dde, do you have any suggestions for how to get around this? I think the way forward may be to simply stop using
cargo readme, as our README files are quite verbose. Instead, I would propose having a short static README for each crate, directing users interested in full docs over to our docs.rs pages. What do you think?In any case, this should happen in a separate PR.