feat(taskbroker): Create Worker Service#186
Merged
james-mcnulty merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
james-mcnulty
changed the title
james-mcnulty
changed the title
james-mcnulty
changed the title
james-mcnulty
changed the title
fpacifici
approved these changes
Mar 16, 2026
| } | ||
|
|
||
| message PushTaskRequest { | ||
| TaskActivation task = 1; |
There was a problem hiding this comment.
Are you using the TaskActivation because GetTaskResponse uses it ?
Do you know TaskActivation is intentionally reused between Kafka and the broker or whether that was a coincidence ?
Member
Author
There was a problem hiding this comment.
Using it because GetTaskResponse uses it. Not sure about the Kafka thing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
STREAM-819
Description
Currently, taskworkers pull tasks from taskbrokers via RPC. This approach works, but has some drawbacks. Therefore, we want taskbrokers to push tasks to taskworkers instead. Read this page on Notion for more information.
Each taskworker now has its own service with a
PushTaskmethod that accepts a task to be executed.Details
WorkerServiceservice withPushTaskmethodPushTaskRequestandPushTaskResponsemessages