fix(nextjs): Expose an event id when captureUnderscoreErrorException captures an exception#19185
Open
andreiborza wants to merge 1 commit intodevelopfrom
Open
fix(nextjs): Expose an event id when captureUnderscoreErrorException captures an exception#19185andreiborza wants to merge 1 commit intodevelopfrom
captureUnderscoreErrorException captures an exception#19185andreiborza wants to merge 1 commit intodevelopfrom
Conversation
…` captures an exception `captureException` returns an event id that can be used for further logging and exposing it to users. `captureUnderscoreErrorException` uses `captureException` under the hood but swallows the underlying event id if the error ends up being captured. We also have `Sentry.lastEventId()` which could be used in the case the event was actually captured, however, in the case that `captureUnderscoreErrorException` does not call `captureException`, `Sentry.lastEventId()` might still return a previously attained id, misleading users. This PR surfaces the underlying event id, if an event was captured and resolves in undefined otherwise. Closes: #19166
Contributor
Codecov Results 📊Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
captureExceptionreturns an event id that can be used for further logging and exposing it to users.captureUnderscoreErrorExceptionusescaptureExceptionunder the hood but swallows the underlying event id if the error ends up being captured.We also have
Sentry.lastEventId()which could be used in the case the event was actually captured, however, in the case thatcaptureUnderscoreErrorExceptiondoes not callcaptureException,Sentry.lastEventId()might still return a previously attained id, misleading users.This PR surfaces the underlying event id, if an event was captured and resolves in undefined otherwise.
Closes: #19166