ref(core): Unref more timers in server and runtime-agnostic code#19177
Draft
ref(core): Unref more timers in server and runtime-agnostic code#19177
Conversation
Lms24
changed the title
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wraps a bunch of
setTimeoutandsetIntervalcalls withsafeUnrefto unref each created timer.unref'ing these timers avoids stalling the process exit in Node and other server runtimes.Not sure if any of these timers actually cause hangs but we've had reports and fixes in the past for some of them. I figured, better safe than sorry here but we'll see if CI agrees with me :D
Note: Some of these changes only replace a manual
.unref()call with thesafeUnrefwrapper. I figured it's probably better to always use safeUnref, should code ever end up in runtimes not supporting unref'ing.